fix: change tooltip from Toggle numbering to Toggle cell alignment#2938
Open
Prashant27-07 wants to merge 1 commit intoMoganLab:mainfrom
Open
fix: change tooltip from Toggle numbering to Toggle cell alignment#2938Prashant27-07 wants to merge 1 commit intoMoganLab:mainfrom
Prashant27-07 wants to merge 1 commit intoMoganLab:mainfrom
Conversation
Author
|
Fixes #2852 |
Contributor
|
You should only change the behavior in tabular-like environment. The current change is global so when it comes to the math mode, it becomes: 
|
Contributor
|
Also, documentation and PR number are required. |
Prashant27-07
added a commit
to Prashant27-07/mogan
that referenced
this pull request
Mar 5, 2026
Prashant27-07
force-pushed
the
fix-toggle-numbering-tooltip
branch
from
7c22ae7 to
4abd0e7
Compare
Prashant27-07
force-pushed
the
fix-toggle-numbering-tooltip
branch
from
4abd0e7 to
53d3326
Compare
Author
|
Hi @JackYansongLi I have updated the fix. The tooltip change is now only applied in tabular context using table-markup-context? in table-menu.scm. The generic-menu.scm and text-menu.scm are reverted back to 'Toggle numbering'. Please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the tooltip "Toggle numbering" was misleading - the button actually toggles cell alignment (tabular vs tabular*), not numbering. Changed the tooltip to "Toggle cell alignment" in generic-menu.scm and text-menu.scm.